[BHBC-899] Align Create Project Form to the Design Spec

[jeznorth]

BHBC-899

Summary	Align Create Project form to the design spec
Type	Task
Status	In Progress
Points	N/A
Labels	-

---

Continued work on UI updates for the project forms

BCBC-899

• {Include links to all of the applicable Jira tickets}

This PR contains the following changes

• Layout updates to the Funding Source Dialog interface
• Small updates to global styling (scss)
• Theme updates in appTheme

This PR contains the following types of changes

• New feature (change which adds functionality)
• Enhancement (improvements to existing functionality)
• Bug fix (change which fixes an issue)
• Misc cleanup / Refactoring / Documentation
• Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

• I have performed a self-review of my own code

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

[github-actions]

Knock Knock! 🔍

Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR.

An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️

Story Title	Align Create Project form to the design spec
PR Title	[BHBC-899] Funding Source Dialog UI Update

Check out this guide to learn more about PR best-practices.

[codecov]

Codecov Report

Merging #167 (66d3263) into dev (529b8a5) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #167   +/-   ##
=======================================
  Coverage   47.05%   47.05%           
=======================================
  Files         115      115           
  Lines        2289     2289           
  Branches      535      535           
=======================================
  Hits         1077     1077           
  Misses       1122     1122           
  Partials       90       90           

Impacted Files	Coverage Δ
app/src/features/projects/CreateProjectPage.tsx	67.30% <ø> (ø)
...res/projects/components/ProjectFundingItemForm.tsx	40.74% <0.00%> (ø)
app/src/themes/appTheme.ts	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529b8a5...66d3263. Read the comment docs.

[sdevalapurkar]

[sdevalapurkar]

can we turn this into a non-draft and get it merged in?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication