Front end for editing species #170

anissa-agahchen · 2021-03-26T00:13:30Z

Overview

This PR contains the following changes

Front -end for editing the Species Component

General

I have performed a self-review of my own code

Code

New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
I have avoided duplicating code when possible, moving re-usable pieces into functions
I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
My code changes account for null/undefined values and handle errors appropriately
My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

My code follows the established style conventions
My code uses native material-ui components/icons/conventions when possible

Documentation

I have commented my code sufficiently, such that an unfamiliar developer could understand my code
I have added/updated README's and related documentation, as needed

Tests

I have added/updated unit tests for any code I've added/updated
I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

I have run the linter and fixed any issues, as needed
See the lint commands in package.json
I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

…iesFE

github-actions · 2021-03-26T00:13:48Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

codecov · 2021-03-26T00:25:05Z

Codecov Report

Merging #170 (c6150b2) into dev (8369eee) will increase coverage by 0.61%.
The diff coverage is 65.71%.

@@            Coverage Diff             @@
##              dev     #170      +/-   ##
==========================================
+ Coverage   47.97%   48.59%   +0.61%     
==========================================
  Files         115      115              
  Lines        2414     2447      +33     
  Branches      556      562       +6     
==========================================
+ Hits         1158     1189      +31     
- Misses       1155     1157       +2     
  Partials      101      101

Impacted Files	Coverage Δ
api/src/models/project-view.ts	`62.96% <ø> (-1.45%)`	⬇️
api/src/paths/project/{projectId}/update.ts	`0.00% <0.00%> (ø)`
api/src/paths/project/{projectId}/view.ts	`0.00% <ø> (ø)`
api/src/queries/project/project-view-queries.ts	`100.00% <ø> (ø)`
...ents/fields/MultiAutocompleteFieldVariableSize.tsx	`33.33% <0.00%> (ø)`
...es/projects/components/ProjectPartnershipsForm.tsx	`100.00% <ø> (ø)`
app/src/features/projects/view/ProjectDetails.tsx	`100.00% <ø> (ø)`
app/src/types/yup.d.ts	`0.00% <ø> (ø)`
.../src/features/projects/view/components/Species.tsx	`86.11% <81.48%> (-13.89%)`	⬇️
api/src/models/project-view-update.ts	`85.71% <85.71%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8369eee...c6150b2. Read the comment docs.

…iesFE

github-actions · 2021-03-26T03:14:31Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T03:21:16Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T03:33:56Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T03:57:50Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T04:10:32Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T05:51:53Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T06:59:54Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

api/src/queries/project/project-view-queries.test.ts

app/src/features/projects/components/ProjectSpeciesForm.tsx

app/src/features/projects/view/components/Species.tsx

github-actions · 2021-03-26T17:36:39Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

sdevalapurkar

need to do something like this:

const handleDialogEditOpen = async () => {
    let speciesResponseData;

    try {
      const response = await biohubApi.project.getProjectForUpdate(id, [UPDATE_GET_ENTITIES.species]);

      if (!response?.species) {
        showErrorDialog({ open: true });
        return;
      }

      speciesResponseData = response.species;
    } catch (error) {
      const apiError = new APIError(error);
      showErrorDialog({ dialogText: apiError.message, open: true });
      return;
    }

    setSpeciesForUpdate(speciesResponseData );

    setOpenEditDialog(true);
  };

github-actions · 2021-03-26T18:17:07Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

app/src/features/projects/view/components/Species.tsx

github-actions · 2021-03-26T18:31:41Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T18:53:54Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T18:55:21Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

app/src/features/projects/view/components/Species.tsx

github-actions · 2021-03-26T19:07:30Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T19:07:44Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T19:07:56Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

github-actions · 2021-03-26T19:11:53Z

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: editspeciesFE

If this is your first time contributing to this repository - welcome!

Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

sonarqubecloud · 2021-03-26T19:25:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.2% Duplication

anissa-agahchen added 5 commits March 25, 2021 09:33

wip

61fdc38

Merge branch 'dev' of https://github.com/bcgov/biohubbc into editspec…

3632739

…iesFE

species populating in edit modal

c165568

updated existing tests

6e07df3

tests for new functions

dc3deef

anissa-agahchen added 2 commits March 25, 2021 19:56

Merge branch 'dev' of https://github.com/bcgov/biohubbc into editspec…

28c25c4

…iesFE

resolve merge conflicts with dev

f66045a

anissa-agahchen marked this pull request as ready for review March 26, 2021 03:20

Trigger Build

962e7a1

format and duplication

add5881

added tests

a8a6e64

small change

bb77196

fixes

a1c6b3f

anissa-agahchen added 4 commits March 25, 2021 23:10

remove duplicate

1bcb31d

Trigger Build

0661f66

Trigger Build

ddff040

rebasing

f14445e

anissa-agahchen requested review from NickPhura and sdevalapurkar March 26, 2021 16:01

NickPhura reviewed Mar 26, 2021

View reviewed changes

api/src/queries/project/project-view-queries.test.ts Outdated Show resolved Hide resolved

NickPhura reviewed Mar 26, 2021

View reviewed changes

app/src/features/projects/components/ProjectSpeciesForm.tsx Outdated Show resolved Hide resolved

sdevalapurkar reviewed Mar 26, 2021

View reviewed changes

app/src/features/projects/view/components/Species.tsx Outdated Show resolved Hide resolved

app/src/features/projects/view/components/Species.tsx Outdated Show resolved Hide resolved

resolved feedback

b72af40

sdevalapurkar reviewed Mar 26, 2021

View reviewed changes

lint and other issues

9a4d607

sdevalapurkar reviewed Mar 26, 2021

View reviewed changes

app/src/features/projects/view/components/Species.tsx Outdated Show resolved Hide resolved

app/src/features/projects/view/components/Species.tsx Show resolved Hide resolved

use callback

a924100

anissa-agahchen added 3 commits March 26, 2021 11:39

clean up

fb44fcd

merge conflicts

821cfe0

snapshot

fe4c593

clean up

f7e11da

anissa-agahchen changed the title ~~Editspecies fe~~ Front end for editing species Mar 26, 2021

sdevalapurkar reviewed Mar 26, 2021

View reviewed changes

app/src/features/projects/view/components/Species.tsx Show resolved Hide resolved

app/src/features/projects/view/components/Species.tsx Show resolved Hide resolved

sdevalapurkar added 2 commits March 26, 2021 12:07

Update app/src/features/projects/view/components/Species.tsx

164f60e

Update app/src/features/projects/view/components/Species.tsx

3b73b29

sdevalapurkar previously approved these changes Mar 26, 2021

View reviewed changes

fix format

c6150b2

sdevalapurkar dismissed their stale review via c6150b2 March 26, 2021 19:11

sdevalapurkar approved these changes Mar 26, 2021

View reviewed changes

sdevalapurkar merged commit 023768c into dev Mar 26, 2021

sdevalapurkar deleted the editspeciesFE branch March 26, 2021 19:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Front end for editing species #170

Front end for editing species #170

anissa-agahchen commented Mar 26, 2021 •

edited

Loading

github-actions bot commented Mar 26, 2021

codecov bot commented Mar 26, 2021 •

edited

Loading

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

sdevalapurkar left a comment

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

sonarqubecloud bot commented Mar 26, 2021

Front end for editing species #170

Front end for editing species #170

Conversation

anissa-agahchen commented Mar 26, 2021 • edited Loading

Overview

This PR contains the following changes

General

Code

Style

Documentation

Tests

Linting/Formatting

SonarCloud

How Has This Been Tested?

Screenshots

github-actions bot commented Mar 26, 2021

codecov bot commented Mar 26, 2021 • edited Loading

Codecov Report

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

sdevalapurkar left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

github-actions bot commented Mar 26, 2021

sonarqubecloud bot commented Mar 26, 2021

anissa-agahchen commented Mar 26, 2021 •

edited

Loading

codecov bot commented Mar 26, 2021 •

edited

Loading