Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IUCN Frontend - Wiring #172

Merged
merged 6 commits into from
Mar 26, 2021
Merged

IUCN Frontend - Wiring #172

merged 6 commits into from
Mar 26, 2021

Conversation

sdevalapurkar
Copy link
Contributor

Overview

This PR contains the following changes

  • IUCN Frontend - Wiring

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)

How Has This Been Tested?

  • Locally

Screenshots

Screenshot 2021-03-26 102256

Screenshot 2021-03-26 102321

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-iucn-fe

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #172 (1d78812) into dev (db5aa9e) will increase coverage by 0.42%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #172      +/-   ##
==========================================
+ Coverage   47.54%   47.97%   +0.42%     
==========================================
  Files         115      115              
  Lines        2362     2414      +52     
  Branches      549      556       +7     
==========================================
+ Hits         1123     1158      +35     
- Misses       1134     1155      +21     
+ Partials      105      101       -4     
Impacted Files Coverage Δ
api/src/openapi/schemas/project.ts 100.00% <ø> (ø)
api/src/paths/project/{projectId}/update.ts 0.00% <0.00%> (ø)
app/src/components/dialog/EditDialog.tsx 100.00% <ø> (ø)
...c/features/projects/components/ProjectIUCNForm.tsx 75.00% <ø> (+10.71%) ⬆️
app/src/features/projects/view/ProjectDetails.tsx 100.00% <ø> (ø)
...features/projects/view/components/Partnerships.tsx 93.10% <ø> (ø)
app/src/themes/appTheme.ts 100.00% <ø> (ø)
api/src/models/project-update.ts 39.62% <33.33%> (-0.81%) ⬇️
...es/projects/view/components/IUCNClassification.tsx 83.33% <82.14%> (+3.33%) ⬆️
api/src/queries/project/project-update-queries.ts 38.77% <100.00%> (+10.20%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db5aa9e...1d78812. Read the comment docs.

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-iucn-fe

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-iucn-fe

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdevalapurkar sdevalapurkar merged commit 8369eee into dev Mar 26, 2021
@sdevalapurkar sdevalapurkar deleted the sd-iucn-fe branch March 26, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants