Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full flow of editing objectives #176

Merged
merged 9 commits into from
Mar 29, 2021
Merged

Full flow of editing objectives #176

merged 9 commits into from
Mar 29, 2021

Conversation

anissa-agahchen
Copy link
Contributor

@anissa-agahchen anissa-agahchen commented Mar 26, 2021

BHBC-917
Summary Edit Project Objectives section
Type Story Story
Status In Progress
Points N/A
Labels -

Overview

Links to jira tickets

  • {Include links to all of the applicable Jira tickets}

This PR contains the following changes

  • {List all the relevant changes. If there are many changes across many Jira tickets, organize the changes by Jira ticket}

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

@github-actions
Copy link

I'm a bot and I 👍 this PR title. 🤖

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #176 (6f8318e) into dev (f710924) will increase coverage by 0.19%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #176      +/-   ##
==========================================
+ Coverage   48.52%   48.72%   +0.19%     
==========================================
  Files         116      116              
  Lines        2576     2627      +51     
  Branches      591      601      +10     
==========================================
+ Hits         1250     1280      +30     
- Misses       1222     1237      +15     
- Partials      104      110       +6     
Impacted Files Coverage Δ
api/src/paths/project/{projectId}/update.ts 0.00% <0.00%> (ø)
app/src/features/projects/view/ProjectDetails.tsx 100.00% <ø> (ø)
api/src/models/project-update.ts 44.00% <50.00%> (+1.97%) ⬆️
...res/projects/view/components/ProjectObjectives.tsx 78.37% <77.41%> (-12.54%) ⬇️
api/src/queries/project/project-update-queries.ts 55.17% <100.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f710924...6f8318e. Read the comment docs.

@anissa-agahchen anissa-agahchen changed the title objectives are editing Full flow of editing objectives Mar 28, 2021
@sdevalapurkar sdevalapurkar marked this pull request as ready for review March 29, 2021 16:51
api/src/models/project-update.test.ts Show resolved Hide resolved
api/src/models/project-update.test.ts Outdated Show resolved Hide resolved
api/src/models/project-update.test.ts Outdated Show resolved Hide resolved
api/src/paths/project/{projectId}/update.ts Outdated Show resolved Hide resolved
api/src/queries/project/project-update-queries.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

1 similar comment
@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

@anissa-agahchen anissa-agahchen self-assigned this Mar 29, 2021
@github-actions
Copy link

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status Peer Review
Allowed Statuses In Progress ✔️

Please ensure your jira story is in one of the allowed statuses

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@sdevalapurkar sdevalapurkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge when CI passes

@anissa-agahchen anissa-agahchen merged commit 79109b3 into dev Mar 29, 2021
@anissa-agahchen anissa-agahchen deleted the BHBC-917 branch March 29, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants