Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BHBC-899] Align Create Project Form to the Design Spec #179

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Conversation

jeznorth
Copy link
Contributor

@jeznorth jeznorth commented Mar 29, 2021

BHBC-899
Summary Align Create Project form to the design spec
Type Task Task
Status In Progress
Points N/A
Labels -

Overview

Links to Jira tickets

  • BHBC-899

This PR contains the following changes

  • Layout/content updates to the Funding Source Component Interface

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

@github-actions
Copy link

I'm a bot and I 👍 this PR title. 🤖

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #179 (5e5f74b) into dev (79109b3) will increase coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #179      +/-   ##
==========================================
+ Coverage   48.72%   48.76%   +0.03%     
==========================================
  Files         116      116              
  Lines        2627     2629       +2     
  Branches      601      601              
==========================================
+ Hits         1280     1282       +2     
  Misses       1237     1237              
  Partials      110      110              
Impacted Files Coverage Δ
...eatures/projects/components/ProjectFundingForm.tsx 51.51% <28.57%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79109b3...5e5f74b. Read the comment docs.

@sdevalapurkar sdevalapurkar marked this pull request as ready for review March 29, 2021 20:51
Copy link
Contributor

@sdevalapurkar sdevalapurkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdevalapurkar sdevalapurkar merged commit 2fe8343 into dev Mar 29, 2021
@sdevalapurkar sdevalapurkar deleted the BHBC-899 branch March 29, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants