Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bhbc 913 #181

Merged
merged 16 commits into from
Mar 30, 2021
Merged

Bhbc 913 #181

merged 16 commits into from
Mar 30, 2021

Conversation

anissa-agahchen
Copy link
Contributor

@anissa-agahchen anissa-agahchen commented Mar 30, 2021

BHBC-913
Summary Remove the ability for users to add cents to their funding amounts
Type Bug Bug
Status In Progress
Points N/A
Labels -

Overview

Links to jira tickets

  • {Include links to all of the applicable Jira tickets}

This PR contains the following changes

  • {List all the relevant changes. If there are many changes across many Jira tickets, organize the changes by Jira ticket}

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

@github-actions
Copy link

Knock Knock! 🔍

Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR.

An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️
Story Title Remove the ability for users to add cents to their funding amounts
PR Title Bhbc 913

Check out this guide to learn more about PR best-practices.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #181 (5c4bfae) into dev (142e3c9) will increase coverage by 0.08%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #181      +/-   ##
==========================================
+ Coverage   52.28%   52.36%   +0.08%     
==========================================
  Files         116      117       +1     
  Lines        2737     2748      +11     
  Branches      633      634       +1     
==========================================
+ Hits         1431     1439       +8     
- Misses       1196     1198       +2     
- Partials      110      111       +1     
Impacted Files Coverage Δ
api/src/queries/project/project-view-queries.ts 100.00% <ø> (ø)
...eatures/projects/components/ProjectFundingForm.tsx 51.51% <ø> (ø)
...res/projects/components/ProjectFundingItemForm.tsx 46.42% <ø> (+1.60%) ⬆️
...eatures/projects/view/components/FundingSource.tsx 100.00% <ø> (ø)
app/src/utils/Utils.ts 90.00% <50.00%> (-10.00%) ⬇️
app/src/components/fields/DollarAmountField.tsx 75.00% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142e3c9...5c4bfae. Read the comment docs.

app/package.json Outdated Show resolved Hide resolved
@anissa-agahchen anissa-agahchen marked this pull request as ready for review March 30, 2021 21:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anissa-agahchen anissa-agahchen merged commit 52f0942 into dev Mar 30, 2021
@anissa-agahchen anissa-agahchen deleted the BHBC-913 branch March 30, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants