Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better test coverage #191

Merged
merged 2 commits into from
Apr 1, 2021
Merged

better test coverage #191

merged 2 commits into from
Apr 1, 2021

Conversation

sdevalapurkar
Copy link
Contributor

Overview

better test coverage

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-tests-

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #191 (d713fae) into dev (e2f072f) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #191      +/-   ##
==========================================
+ Coverage   55.52%   55.98%   +0.46%     
==========================================
  Files         111      111              
  Lines        2723     2722       -1     
  Branches      607      606       -1     
==========================================
+ Hits         1512     1524      +12     
+ Misses       1089     1083       -6     
+ Partials      122      115       -7     
Impacted Files Coverage Δ
...features/projects/components/ProjectPermitForm.tsx 87.50% <ø> (+6.25%) ⬆️
...ures/projects/view/components/LocationBoundary.tsx 100.00% <100.00%> (+1.75%) ⬆️
...es/projects/view/components/GeneralInformation.tsx 100.00% <0.00%> (+6.97%) ⬆️
app/src/features/projects/view/ProjectPage.tsx 100.00% <0.00%> (+8.33%) ⬆️
.../src/features/projects/view/ProjectAttachments.tsx 47.82% <0.00%> (+10.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f072f...d713fae. Read the comment docs.

@github-actions
Copy link

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: sd-tests-

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@sdevalapurkar sdevalapurkar merged commit 6ca83e0 into dev Apr 1, 2021
@sdevalapurkar sdevalapurkar deleted the sd-tests- branch April 1, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants