Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to Makefile and docker-compose #195

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

rstens
Copy link
Member

@rstens rstens commented Apr 1, 2021

So you can run clamav locally during test.
Just run make web and all gets build.

Overview

For testing and development purpose, I have added clamav to the Makefile and the docker compose. This will allow you to address clamav an run your tests scans.

This PR contains the following changes

  • See Above

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

General

  • I have performed a self-review of my own code

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have tested locally with the sample clamav client files

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: Adding-ClamAv-to-the-setup-for-local

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #195 (fbf1e2d) into dev (b08aa00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #195   +/-   ##
=======================================
  Coverage   57.40%   57.40%           
=======================================
  Files         107      107           
  Lines        2646     2646           
  Branches      592      592           
=======================================
  Hits         1519     1519           
  Misses       1013     1013           
  Partials      114      114           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08aa00...fbf1e2d. Read the comment docs.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: Adding-ClamAv-to-the-setup-for-local

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@rstens rstens merged commit 1cfc7b8 into dev Apr 1, 2021
@rstens rstens deleted the Adding-ClamAv-to-the-setup-for-local branch April 1, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants