Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to postgres 12 and postgis 3 #20

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Update to postgres 12 and postgis 3 #20

merged 1 commit into from
Jan 8, 2021

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Jan 8, 2021

Overview

Links to jira tickets

This PR contains the following changes

Tiny PR to update to postgres 12 and postgis 3.

The update to postgis was required, as the previous version of 2.4 had a max version of postgres that it would work with, and would throw an error if you tried to run the docker build.

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc and inform future developers

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation

Tests

  • I have added/updated unit tests for any new code I've added/updated
  • I have added/updated Postman tests to account for any new/updated code

How Has This Been Tested?

Locally (via Docker)

Screenshots

Please add any relevant UI screenshots, if applicable.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@NickPhura NickPhura requested a review from popkinj January 8, 2021 04:07
@NickPhura
Copy link
Collaborator Author

@popkinj
I had to increase the version of postgis as a side effect of increasing the version of postgres.

I assume that should be just fine?

Postgis 2.5 or 3 were allowed options, so I just went with 3.

Copy link
Contributor

@anissa-agahchen anissa-agahchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end.

Copy link
Contributor

@popkinj popkinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... Definitely PostGIS 3.X.
There is actually version 3.1.0 available. But I'm not sure it's necessary for us yet.

@NickPhura NickPhura merged commit d4b8e8e into dev Jan 8, 2021
@NickPhura NickPhura deleted the Update_Postgres branch January 8, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants