BHBC-1023: Front end work for - Create Survey API and connect to Save and exit button #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #278 +/- ##
==========================================
+ Coverage 65.77% 66.26% +0.48%
==========================================
Files 152 152
Lines 4351 4390 +39
Branches 978 983 +5
==========================================
+ Hits 2862 2909 +47
- Misses 1403 1413 +10
+ Partials 86 68 -18
Continue to review full report at Codecov.
|
|
Are the Proprietary Information fields supposed to toggle based on the I'm guessing the idea is that if they say Looks good though! |
|
Kudos, SonarCloud Quality Gate passed!
|
Yeah I wasn't really aware of that requirement but makes sense. I can definitely add it in 😃 |
There is also the requirement that if the category selection is a first_nations_category, then the proprietor field is populated from the first_nations table. Not sure what the expected behaviour is if the category selected is not a first nation. This could definitely be in a future PR though. |
anissa-agahchen
approved these changes
May 5, 2021
rstens
added a commit
that referenced
this pull request
May 13, 2021
* readme update to test the test pipeline (#204) (#205) * Error message that users can have duplicate entries on IUCN, species and permits (#196) * Error message that users can have duplicate entries on IUCN, species and permits * put back * fix * awesome * better test * this is great * this is great actually * fix * more tests * try * fixtest * species validation too * fix * BHBC-964: File upload component + tests (#203) * BHBC-964: File upload component + tests * Remove unused variables/classes. Update tests. * Update tests Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-964: Additional UI tweaks and test updates (#208) * BHBC-964: Additional UI tweaks and test updates * More missing tests (#210) * add test case for mapcontainer * add dollarfield test * fix formatting * add public layout tests (#209) * add public layout tests * wording * [BHBC-965] Project Page UI Clean-up / Refactor Markup (#212) * [BHBC-965] Project Page UI Clean-up / Refactor Markup * Trigger Build * Update app/src/features/projects/view/ProjectPage.tsx Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-969 (#213) * model changes for attachments and lookup values for system and project roles * model changes for attachments and lookup values for system and project roles * remove unneeded file and remove merge artifact * fixed format Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-934: Edit funding rework (#207) BHBC-934: Edit funding rework * Implement the designs for listing attachments & Enhance file upload end-points (#214) * basic attachments list view and retrieve * wip * more wip * it works ete * fix formatting * minor snap update * final cleaning * fix format * fix duplication * trigger build * update * fix format * update date fix * rollback * Scaling down and better cleanse (#215) * Scaling down and better cleanse * Imporve the order * Formatting * Debug * Debug 2 * awk update * AWK special chars * xx * remove stange character * update the static * first (#216) * BHBC-914: Save drafts (#211) * BHBC-914: Save drafts * Reduce duplication * Code review updates * Fix merge issue Co-authored-by: Shreyas Devalapurkar <[email protected]> * Add missing attachments tests (#217) * backend tests for attachments * frontend tests for attachments * remove * fixes * coverage * Cleanup 😄🗑️ (#218) * delete unused files * more removal * BHBC-964 (#219) * BHBC-964: file upload improvements * update tests * Remove console log * Update unit tests * Remove unused import Co-authored-by: Shreyas Devalapurkar <[email protected]> * Add missing tests and fix FE warning (#221) fix front end functionality * Improve the user seed to only seed users as needed. (#224) * [BHBC-965] Project Page UI Clean-up / Refactor Markup (#223) * [BHBC-965] Project Page UI Clean-up / Refactor Markup * [BHBC-965] Null / Undefined Fixes * [BHBC-965] Fix Formatting Co-authored-by: Shreyas Devalapurkar <[email protected]> * Add delete funding (#220) Add and delete funding from the project view change * Implement functionality to view draft projects in the project list (#222) Implement functionality to view draft projects in the project list * Code cleanup and tests (#225) Code cleanup and tests * BHBC-973 Db modelling for tracking user requests (#228) * BHBC-973 - addition of persistance targets to support work ledger tables: administrative_activity administrative_activity_type administrative_activity_status_type - modification of audit dates to UTC - various description updates * BHBC-973 - addition of persistance targets to support work ledger tables: administrative_activity administrative_activity_type administrative_activity_status_type - modification of audit dates to UTC - various description updates * adjusted jira status for pr check * add delete confirmation dialog on attachment delete (#227) * add delete confirmation dialog on attachment delete * BHBC-914: Drafts now save WIP steps correctly. (#230) * API Tests (#229) * awesome tests * add test cases to get file coverage to 100% (#231) * get many files to 100% coverage * Add missing tests to code queries file (#233) * add missing tests (#234) Co-authored-by: Nick Phura <[email protected]> * Add missing FE tests (#235) * add missing fe tests * Build time improvements (maybe??) (#232) Replace all dereferenced material-ui imports with individual imports to improve performance (hopefully?) * Bhbc 964 (#236) * Improvements to file upload components * BHBC-964: Update tests * Update imports * Adding a new funding source test case (#237) add funding source test case * Implement functionality to edit draft projects (#238) * wip * end to end * add queries tests * fix code smell * add initial load test * add tests * trigger build * add test case * pr feedback * fix * fix code smell * small fix * fix and refactor duplicate code * Implement Permit session in the Create Project and View Project page (#241) * wip, got it working * more wip, add basic tests * format * code smell * add tests * fix test * add test case * missing dependencies * [BHBC-965] Project Page UI Clean-up / Refactor Markup (#242) * [BHBC-965] Project Page UI Clean-up / Refactor Markup * [BHBC-965] Fix Formatting * Trigger Build Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-714 Delete a project (#243) * - added procedure api_delete_project * - added procedure api_delete_project * Update database/src/migrations/release.0.11/api_delete_project.sql Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Shreyas Devalapurkar <[email protected]> * Edit the Permits section in the View Project page (#244) * User denied access to BioHub (#245) improved access-denied page, and page-not-found page * BHBC-985: System user role updates (#240) * BHBC-985: System user role updates - Add support for authorization in API - Add support for database connections with the API's user in context - Fixed bug where BCEID users weren't being parsed correctly in db.ts - Add systemRole support to useKeycloakWrapper.tsx - Add endpoint to fetch user information - Incorporated Charlie's context updates to allow the API to be set as the database context user. * BHBC-985: Updates to sql and api role checks * - Review updates - Remove system role checking in APi until we are ready to enforce it * BHBC-900: Use management page + accesss request list (#246) * BHBC-900: Manage users page + access requests list * Updates * Code review updates + formatting + snapshot fixes * Add 'Not Applicable' defaults to access request list * Remove old TODO, join regional_offices in UI * BHBC-983 Add permit type field to the DB (#247) * - added attribute type to tables project_permit and no_sample_permit * - adding attribute type to tables project_permit and no_sample_permit Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-900: Tests + minor updates (#248) BHBC-900: Tests + minor updates + fix roles * Active Users List (#249) * new file * wip * add a test * add test * add test case * Trigger Build * address feedback and add test case Co-authored-by: Anissa Agahchen <[email protected]> * Add test coverage ✔️ (#252) * Add permit type field to permit section (create, view, and edit) (#251) * Request access page (#239) * basic page added * very basic routing based on a page needing a valid role * got api working with hardcoded userid * role can be selected * wip * access-request linked to the forbidden page * more wip * format and such * standard errors * update * redirects * updates * format * fix * tests * clean ups * tests * updated snapshot * remove comments * one more test * remove code smell * broken wip * bunch of updates * updates * lint * cleanups * final * Misc code updates Co-authored-by: Nick Phura <[email protected]> * Remove test route roles (#254) * Remove test route roles * Fix formatting * Various tests and cleanups (#253) * add tests (#256) * BHBC-993: Review access requests + misc user/role management endpoints + misc cleanup (#255) * BHBC-993: Review access requests + misc user/role management endpoints + misc cleanup * Allow users to navigate the Create Project form out of order (#257) * ability to navigate create project flow out of order * small fix * pr feedback and a test case * fix test coverage * testing project funding item form and changes to draft wording and exiting automatically * project iucn form tests * fixes and merge conflicts, nicks optimization * API tests unlocked and permit/create project flow fixes (#259) * BHBC-993: Misc Updates + tests (#258) * Add email to the data blob for access requests, show in UI (#260) * Get self.ts to 100% coverage (#261) * Moar Tests (#263) * Add unit tests for request dialog * More tests * Review updates * Get user.ts to 100% coverage (#262) * Get codes.ts from 0-100 coverage and also permit-no-sampling coverage to 76% (#265) * codes.ts from 0-100 coverage * add test case * more tests * Aa more tests (#264) * wip * more wip * got tests working * resolved feedback * fix * Implement the project metadata description text in the UI (#267) * all fixes * update fields on projects list * proper fields in test mock * final cleaning * BHBC-986: Update endpoint roles and hide manage users link (#266) * Delete jira-lint.yml (#269) * Update Db code table content (#270) * wip * final fix * Surveys List Component (#268) * survey list component * tests and snaps * dont use snapshots * trigger build * trigger build * fix issue * trigger build * BHBC 1015 + 1016 - Structure and data passing for creating surveys in the UIs (#273) * basic changes * basic routing with hardcoded projectId * outer structure done * structure completed * cleanup * tests updates * addressing feedback * code smells * Update app/src/features/surveys/CreateSurveyPage.tsx * Update app/src/features/surveys/CreateSurveyPage.tsx * Update app/src/features/surveys/CreateSurveyPage.tsx * Update app/src/features/surveys/CreateSurveyPage.tsx * trigger build * format fix Co-authored-by: Anissa Agahchen <[email protected]> * Study area form, general information form, proprietary data form, and agreements form component (surveys) (#271) * Study area form component * add generalinformationform * update comment * add proprietary data forms * trigger build * add agreements form * implement forms into layout * Some missing surveys-related tests (#274) * Bhbc 1013 (#276) * BHBC - 1013 - addition of survey metadata tables * BHBC - 1013 - addition of survey metadata tables * - run lint Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Shreyas Devalapurkar <[email protected]> * xl not lg (#277) * xl not lg * snap * BHBC-981: Update create project page to wizard style (#275) * BHBC-1013 2 (#279) * BHBC-1013 v2 - added survey.location_name - moved survey.disa_required to survey_proprietor.disa_required * BHBC-1013 v2 - added survey.location_name - moved survey.disa_required to survey_proprietor.disa_required Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Anissa Agahchen <[email protected]> * BHBC-1023: Front end work for - Create Survey API and connect to Save and exit button (#278) * Merge branch 'dev' of https://github.com/bcgov/biohubbc into adding-c… (#281) * Merge branch 'dev' of https://github.com/bcgov/biohubbc into adding-cypress * Update snaps * BHBC-1013 v3 (#283) * Updates to proprietary data section of create survey (#282) * make proprietary data section conditionally visible * show disa at all times * first nations * fix issues * one missing test case * Update autocomplete field to allow single elements and string/numbers (#285) * add first nations id field to send to api (#287) * BHBC: 1033 -> First pass on survey view page (not wired with backend) (#286) * Test more things and refactoring (#288) * BHBC-1007 (#289) * BHBC-1013 v3 - removed survey.is_FOIPA * BHBC-1007 - added table wldtaxonomic_units Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-1021 API built to receive survey creation requests (#284) * some tests (#290) * some tests * fix Co-authored-by: Shreyas Devalapurkar <[email protected]> * Viewing surveys in list and details on view page (#291) * getting the right view data back * list view, end to end * finalize * formatting ugh * remove * bceid user request (#292) * Edit general information survey metadata and other fixes/changes (#293) * wip * fixes * got edit gi working * format:fix * clean * code smell/duplication * improvements * format:fix * test fixes * wording * fix * pr feedback * feedback: * missing tests for survey stuff (part 1 of many) (#295) * missing test * test 2 * BHBC-989- Assign project owner role to BCeID user (#296) * more missing api tests for surveys (#297) * more survey api tests (#298) * New updates (#300) * Shapefile uploads on map (#299) * Button with tooltip * Testing file type * Install dependencies * More dependencies * trying to load zip file * Shapefile converting to GeoJSON * Cleaning up * doc * Updating tooltip * Removing unused dependencies * Not sure how this got here * Uploading shapefile * upper scope * Tests passing * Linting * Removing catching * Removed titles * wip * Logs * format fix * no log * Different tile type checks * Null check * fix tests * Await instead of a callback * semicolon * this is a dev dependency Co-authored-by: Shreyas Devalapurkar <[email protected]> * BHBC-992: Log out / Log in (#294) * BHBC-992: Logout - Add util for siteminder + keycloak logout - Add username + logout button to header - Add log in page - Update routing to allow for un-authenticated pages * BHBC-992: Add siteminder url to env/pipeline/etc * Trigger build * BHBC-992: Add siteminder env to app config (accidentally added to api config) * BHBC-992: Review updates + add tests + fix existing tests * BHBC-992: Fix issue where submitting an access request would not route you correctly to the request submitted page - Added a `refresh` function to the keycloak wrapper * Update app/src/pages/login/LogInPage.tsx * BHBC-992: Remove auto-redirect to access request page Co-authored-by: Anissa Agahchen <[email protected]> Co-authored-by: Shreyas Devalapurkar <[email protected]> * Updated the code to work with a test id. (#305) * Updated the code to work with a test id. * Added new test users to seed * Change test names in seed * 🤖 Transformers, dependabots in disguise (#307) * Bump hosted-git-info from 2.8.8 to 2.8.9 in /api (#304) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump hosted-git-info from 2.8.8 to 2.8.9 in /database (#303) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump lodash from 4.17.20 to 4.17.21 in /api (#302) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump lodash from 4.17.20 to 4.17.21 in /database (#301) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * survey list/create test (#306) * start tests * get to 100 * progress on create survey tests * all survey backend is tested * final Co-authored-by: Anissa Agahchen <[email protected]> * BHBC-992-2: Fix infinite loop if an existing user with a role requests access (#308) - Add/Update some tests * Added/updated tests for the forbidden page (#310) * getAddSystemRolesHandler tests (#309) * more tests * clean up * Test code adjustment (#311) * Test code adjustment * Select regions * add funding source tests complete (#312) * add funding source tests complete * more tests * update * Add surveygeneralinformation tests (#313) * Add a map to the survey metadata to record survey boundary (#315) * more tests for deleting funding source (#314) * more tests for deleting funding source * fixed test Co-authored-by: Shreyas Devalapurkar <[email protected]> Co-authored-by: Shreyas Devalapurkar <[email protected]> Co-authored-by: Nick Phura <[email protected]> Co-authored-by: jeznorth <[email protected]> Co-authored-by: Charlie Garrett-Jones <[email protected]> Co-authored-by: charlie garrett-jones <charlie.garrettjones@bayseumcom> Co-authored-by: Anissa Agahchen <[email protected]> Co-authored-by: Nick Phura <[email protected]> Co-authored-by: Jamie Popkin <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Links to jira tickets
This PR contains the following changes
This PR contains the following types of changes
How Has This Been Tested?