Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bhbc 1149 #362

Merged
merged 10 commits into from
Jun 14, 2021
Merged

Bhbc 1149 #362

merged 10 commits into from
Jun 14, 2021

Conversation

anissa-agahchen
Copy link
Contributor

Overview

Links to jira tickets

https://quartech.atlassian.net/browse/BHBC-1149

This PR contains the following changes

  • The block_observation table built using Knex migrations, with related view and audit trigger

This PR contains the following types of changes

  • New feature (change which adds functionality)

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #362 (2fc39e8) into dev (abc2b3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #362   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         198      198           
  Lines        5889     5889           
  Branches     1323     1323           
=======================================
  Hits         4365     4365           
  Misses       1398     1398           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc2b3a...2fc39e8. Read the comment docs.

Copy link
Contributor

@sdevalapurkar sdevalapurkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work
few comments

database/README.md Show resolved Hide resolved
database/README.md Show resolved Hide resolved
database/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sdevalapurkar sdevalapurkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anissa-agahchen anissa-agahchen merged commit b737572 into dev Jun 14, 2021
@anissa-agahchen anissa-agahchen deleted the BHBC-1149 branch June 14, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants