Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N8n bc bug #438

Merged
merged 3 commits into from
Jul 30, 2021
Merged

N8n bc bug #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e2d7bd
OpenShift bc and dc
rstens Jul 30, 2021
163e358
remove the build namespace
rstens Jul 30, 2021
6f12c36
Merge branch 'dev' into n8n-bc-bug
rstens Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions containers/n8n/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ You are supposed to build your n8n image in your <..>-tools namespace and then w
While N8N does provide a Docker image [here](https://hub.docker.com/r/n8nio/n8n), it is not compatible with OpenShift due to the image assuming it has root privileges. Instead, we build a simple NodeJS image based off Redhat's ubi8/nodejs-12 image where the N8N application can execute without needing privilege escalation. In order to build a N8N image in your project, process and create the build config template using the following command (replace anything in angle brackets with the correct value):

```sh
oc process -n $NAMESPACE -f n8n.bc.yaml -p N8N_VERSION=$N8N_VERSION N8N_IMAGE_NAMESPACE=$N8N_IMAGE_NAMESPACE -o yaml | oc apply -n $NAMESPACE -f -

export NAMESPACE=af2668-test
export N8N_IMAGE_NAMESPACE=af2668-tools
export N8N_VERSION=0.131.0

oc process -n $NAMESPACE -f n8n.bc.yaml -p N8N_VERSION=$N8N_VERSION -p N8N_IMAGE_NAMESPACE=$N8N_IMAGE_NAMESPACE -o yaml | oc apply -n $NAMESPACE -f -

```

This will create an ImageStream called `n8n`. This image is built on top of ubi8/nodejs-12, and will have N8N installed on it.
Expand Down
5 changes: 0 additions & 5 deletions containers/n8n/n8n.bc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ labels:
template: "${NAME}-bc-template"
metadata:
name: "${NAME}"
namespace: "${N8N_IMAGE_NAMESPACE}"
objects:
- kind: ImageStream
apiVersion: v1
Expand Down Expand Up @@ -82,7 +81,3 @@ parameters:
description: The version tag of the built image
required: true
value: latest
- name: N8N_IMAGE_NAMESPACE
description: Target namespace reference (i.e. '9f0fbe-dev') for the N8N image
displayName: Namespace
required: true