Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seeding to delete itself on re-run + misc #45

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Feb 2, 2021

Overview

This PR contains the following changes

  • Update seeding to delete any seeded rows before running the seeding.
    • Will fix the issue where subsequent runs (locally or in a PR) cause the seeding to fail because of duplicate keys.
  • Fix the formatting for 1 file
  • Push the lock files (as the app lock file hadn't been pushed yet?)

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc and inform future developers

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation

Tests

  • I have added/updated unit tests for any new code I've added/updated
  • I have added/updated Postman tests to account for any new/updated code

How Has This Been Tested?

Locally.

Screenshots

Please add any relevant UI screenshots, if applicable.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #45 (fec60ec) into dev (cfce40f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #45   +/-   ##
=======================================
  Coverage   17.57%   17.57%           
=======================================
  Files          77       77           
  Lines         899      899           
  Branches      182      182           
=======================================
  Hits          158      158           
  Misses        736      736           
  Partials        5        5           
Impacted Files Coverage Δ
api/src/security/auth-utils.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfce40f...fec60ec. Read the comment docs.

@NickPhura NickPhura changed the title Update seeding to delete itself on re-run Update seeding to delete itself on re-run + misc Feb 2, 2021
@NickPhura NickPhura mentioned this pull request Feb 2, 2021
17 tasks
if (verificationError) {
defaultLog.warn({ label: 'verifyToken', message: 'jwt verification error', verificationError });
return null;
return verify(
Copy link
Collaborator Author

@NickPhura NickPhura Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire file has no real code changes, this is just running the formatter.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rstens rstens merged commit c13c82b into dev Feb 3, 2021
@rstens rstens deleted the Update_seeding branch February 3, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants