Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BHBC-1448] Change Email Address #602

Merged
merged 4 commits into from
Oct 19, 2021
Merged

[BHBC-1448] Change Email Address #602

merged 4 commits into from
Oct 19, 2021

Conversation

jeznorth
Copy link
Contributor

@jeznorth jeznorth commented Oct 19, 2021

Overview

BHBC-1448

This PR contains the following changes

  • Updating the access request dialog
  • Small fixes (chip sizing) across a number of interfaces
  • Updating base colors for text based on BC Gov styling conventions

This PR contains the following types of changes

  • New feature (change which adds functionality)
  • Enhancement (improvements to existing functionality)
  • Bug fix (change which fixes an issue)
  • Misc cleanup / Refactoring / Documentation
  • Version change

Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

General

  • I have performed a self-review of my own code

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots, if applicable.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #602 (6cbb38f) into dev (dc2615f) will increase coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #602      +/-   ##
==========================================
+ Coverage   76.80%   76.82%   +0.02%     
==========================================
  Files         287      287              
  Lines       10248    10249       +1     
  Branches     2140     2140              
==========================================
+ Hits         7871     7874       +3     
+ Misses       2043     2041       -2     
  Partials      334      334              
Impacted Files Coverage Δ
app/src/components/attachments/AttachmentsList.tsx 45.45% <ø> (ø)
.../pages/public/components/PublicAttachmentsList.tsx 83.87% <87.50%> (+3.87%) ⬆️
app/src/features/admin/users/AccessRequestList.tsx 88.67% <100.00%> (ø)
app/src/features/projects/view/ProjectPage.tsx 87.09% <100.00%> (ø)
app/src/features/surveys/view/SurveyPage.tsx 73.86% <100.00%> (ø)
app/src/pages/public/PublicProjectPage.tsx 90.32% <100.00%> (ø)
app/src/hooks/api/useExternalApi.ts 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2615f...6cbb38f. Read the comment docs.

@NickPhura NickPhura requested review from anissa-agahchen and removed request for sdevalapurkar October 19, 2021 17:04
@jeznorth jeznorth marked this pull request as ready for review October 19, 2021 17:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anissa-agahchen anissa-agahchen merged commit 4daee9b into dev Oct 19, 2021
@NickPhura NickPhura deleted the BHBC-1448 branch October 19, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants