BHBC-1949: Email notification to Users that access has been granted or denied

[KjartanE]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-1949

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-829-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-829-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=829

[codecov]

Codecov Report

Merging #829 (f9a1d23) into dev (f85ec71) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##              dev     #829      +/-   ##
==========================================
- Coverage   70.81%   70.78%   -0.04%     
==========================================
  Files         333      333              
  Lines       11504    11490      -14     
  Branches     2079     2071       -8     
==========================================
- Hits         8147     8133      -14     
+ Misses       2918     2917       -1     
- Partials      439      440       +1     

Impacted Files	Coverage Δ
api/src/constants/notifications.ts	100.00% <ø> (ø)
api/src/models/user.ts	63.63% <ø> (-9.70%)	⬇️
api/src/paths/gcnotify/send.ts	78.26% <66.66%> (-8.92%)	⬇️
api/src/services/gcnotify-service.ts	100.00% <100.00%> (ø)
app/src/features/admin/users/AccessRequestList.tsx	82.92% <100.00%> (+2.92%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[curtisupshall]

📧

[NickPhura]

A Couple of extra changes that would help clean things up a bit:

• We can probably move the ...models/gcnotify.ts interfaces into the service, as we are moving away from the models concept I think ('models' will likely live in the service and/or repository moving forward).
• In gcnotify-service.ts, it might be nice to define an interface for the data variable (the one with the personalisation field, etc). Just for completeness.

[KjartanE]

A Couple of extra changes that would help clean things up a bit:

• We can probably move the ...models/gcnotify.ts interfaces into the service, as we are moving away from the models concept I think ('models' will likely live in the service and/or repository moving forward).
• In gcnotify-service.ts, it might be nice to define an interface for the data variable (the one with the personalisation field, etc). Just for completeness.

Completed, requesting another review

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
44.7% Duplication