Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2078: Amend summary template validation schema for taxonomic codes #882

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

curtisupshall
Copy link
Contributor

Overview

Updates the summary template species table to reflect all of the Moose, Goat, Sheep and Elk taxonomic codes, so summary template validation doesn’t fail to find validation schema.

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2078

Description of relevant changes

Summary template validation for a given summary template should match on any of the corresponding taxonomic codes given in the survey focal species:

  • Sheep species codes: M-OVCA, M-OVCA-CA, M-OVDA, M-OVDA-DA, M-OVDA-ST
  • Elk species codes: M-CEEL, M-CEEL-RO, M-CECA, M-CECA-RO
  • Moose species codes: M-ALAM, M-ALAL-AN, M-ALAM-GI and M-ALAM-SH
  • Mountain goat codes: M-ORAM

@curtisupshall curtisupshall changed the title BHBC-2078: Amend summary species template validation BHBC-2078: Amend summary template validation schema for taxonomic codes Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #882 (6a72475) into dev (b24f01f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #882   +/-   ##
=======================================
  Coverage   73.47%   73.47%           
=======================================
  Files         351      351           
  Lines       11793    11793           
  Branches     2130     2130           
=======================================
  Hits         8665     8665           
  Misses       2675     2675           
  Partials      453      453           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧀

@NickPhura
Copy link
Collaborator

Reminder that we'll need to drop dev for this to run successfully.

@curtisupshall
Copy link
Contributor Author

Reminder that we'll need to drop dev for this to run successfully.

@NickPhura should we just move this code to a new migration file and upsert the new summary template species records?

AlfredRosenthal
AlfredRosenthal previously approved these changes Dec 7, 2022
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@AlfredRosenthal AlfredRosenthal merged commit 36081df into dev Dec 7, 2022
@AlfredRosenthal AlfredRosenthal deleted the BHBC-2078 branch December 7, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants