Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bhbc 2052 #884

Merged
merged 11 commits into from
Dec 2, 2022
Merged

Bhbc 2052 #884

merged 11 commits into from
Dec 2, 2022

Conversation

AlfredRosenthal
Copy link
Contributor

Overview

Links to Jira tickets

BHBC 2052

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #884 (953b2c9) into dev (c577394) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #884   +/-   ##
=======================================
  Coverage   73.47%   73.47%           
=======================================
  Files         351      351           
  Lines       11793    11793           
  Branches     2130     2130           
=======================================
  Hits         8665     8665           
  Misses       2675     2675           
  Partials      453      453           
Impacted Files Coverage Δ
...pi/src/queries/survey/survey-occurrence-queries.ts 95.65% <ø> (ø)
api/src/services/validation-service.ts 84.95% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlfredRosenthal AlfredRosenthal marked this pull request as ready for review December 1, 2022 18:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlfredRosenthal AlfredRosenthal merged commit 78b6e31 into dev Dec 2, 2022
@AlfredRosenthal AlfredRosenthal deleted the BHBC-2052-Update branch December 2, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants