BHBC-2086 - Don't Show Expired Taxonomic Codes

[curtisupshall]

Overview

New data submitted to SIMS to should use current taxonomic codes so new data isn’t associated with codes that are no longer in use.

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2086

Description of relevant changes

• Modified species search in the Taxonomy service to include a boolean filter on records whose end date has passed;
• Added a new environment variable to deliniate the index name used to search for taxonomic codes in Elasticsearch;
• Enhanced JSDoc and type defs in the Taxonomy service;
• Made all private TaxonomyService methods public and prefixed them by "_".

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-886-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-886-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=886

[codecov]

Codecov Report

Merging #886 (e40822a) into dev (3db7752) will increase coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev     #886      +/-   ##
==========================================
+ Coverage   60.97%   61.06%   +0.08%     
==========================================
  Files         379      379              
  Lines       12224    12229       +5     
  Branches     2177     2181       +4     
==========================================
+ Hits         7454     7468      +14     
+ Misses       4379     4365      -14     
- Partials      391      396       +5     

Impacted Files	Coverage Δ
api/src/services/taxonomy-service.ts	59.37% <42.85%> (+40.85%)	⬆️
api/src/paths/taxonomy/species/search.ts	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlfredRosenthal]

🐯

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication