BHBC-2085 #888
Merged
BHBC-2085 #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #888 +/- ##
==========================================
+ Coverage 62.17% 62.20% +0.03%
==========================================
Files 379 380 +1
Lines 12248 12287 +39
Branches 2176 2183 +7
==========================================
+ Hits 7615 7643 +28
- Misses 4245 4250 +5
- Partials 388 394 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anissa-agahchen
requested review from
AlfredRosenthal,
NickPhura,
KjartanE and
curtisupshall
curtisupshall
previously approved these changes
Dec 14, 2022
A few minor formatting tweaks.
NickPhura
dismissed stale reviews from curtisupshall and AlfredRosenthal
via
3ff1013
- It adds additional details, but may also lead to confusion if that taxon code isnt the issue.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Links to Jira tickets
https://quartech.atlassian.net/browse/BHBC-2085
Description of relevant changes
The work in this ticket is based on the assumption that the darwin_core_source column in the occurrence_submission is populated with the result of the transform as a JSON object.
** finds all paths that contain a taxonID
** queries elastic search for the scientific and common name
** enriches the object at the same path with the scientific and common names
** returns the object
At a later point, this work will be merged with the transfom steps.
Note: look at tests to see how the object transformations