BHBC-2022

[cgarrettjones]

Overview

Links to Jira tickets

• BHBC-2022
• BHBC-1929

Note: this branch is based off of #891

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-896-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-896-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=896

[codecov]

Codecov Report

Merging #896 (7d4a8b9) into dev (4f6ac04) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #896      +/-   ##
==========================================
- Coverage   64.65%   64.59%   -0.07%     
==========================================
  Files         364      361       -3     
  Lines       11655    11626      -29     
  Branches     2097     2090       -7     
==========================================
- Hits         7536     7510      -26     
+ Misses       3727     3725       -2     
+ Partials      392      391       -1     

Impacted Files	Coverage Δ
api/src/models/project-survey-attachments.ts	45.71% <ø> (+1.26%)	⬆️
api/src/models/project-view.ts	100.00% <ø> (ø)
api/src/models/survey-view.ts	100.00% <ø> (ø)
.../src/paths/project/{projectId}/attachments/list.ts	46.66% <ø> (ø)
...t/{projectId}/attachments/{attachmentId}/delete.ts	0.00% <ø> (ø)
api/src/queries/project/project-view-queries.ts	100.00% <ø> (ø)
api/src/queries/queries.ts	100.00% <ø> (ø)
api/src/queries/survey/survey-view-queries.ts	100.00% <ø> (ø)
api/src/repositories/attachment-repository.ts	18.18% <ø> (ø)
api/src/services/attachment-service.ts	16.27% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
11.3% Duplication

[NickPhura]

I think this is good to go now. Fixed one sneaky issue that popped up when viewing the metadata dialog for a report. Everything else seems to work as expected as far as I saw