BHBC-1952

[AlfredRosenthal]

Overview

Links to Jira tickets

BHBC-1952

Description of relevant changes

• Added new file/ script in database to convert JSON objects into validation schema

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-897-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-897-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=897

[codecov]

Codecov Report

Merging #897 (57a9168) into dev (97865c1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev     #897      +/-   ##
==========================================
- Coverage   64.91%   64.90%   -0.01%     
==========================================
  Files         351      351              
  Lines       11163    11163              
  Branches     1986     1986              
==========================================
- Hits         7246     7245       -1     
  Misses       3546     3546              
- Partials      371      372       +1     

Impacted Files	Coverage Δ
...d}/survey/{surveyId}/observation/submission/get.ts	88.37% <ø> (ø)
api/src/services/validation-service.ts	84.97% <ø> (ø)
api/src/utils/media/csv/csv-file.ts	72.54% <ø> (ø)
...rc/utils/media/csv/validation/csv-row-validator.ts	88.52% <0.00%> (-0.82%)	⬇️
...p/src/features/surveys/view/SurveyObservations.tsx	37.83% <ø> (ø)
...src/utils/media/xlsx/validation/xlsx-validation.ts	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication