Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2123: SIMS: Taxonomy Primary Key Does Not Match Between SPI, Shadow Table in SIMS and Elasticsearch Index #901

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Jan 3, 2023

Overview

Links to Jira tickets

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@KjartanE KjartanE changed the title drop table migration functioning BHBC-2123: SIMS: Taxonomy Primary Key Does Not Match Between SPI, Shadow Table in SIMS and Elasticsearch Index Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #901 (cc2a061) into dev (2116f48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #901   +/-   ##
=======================================
  Coverage   63.67%   63.67%           
=======================================
  Files         339      339           
  Lines       10893    10893           
  Branches     1915     1915           
=======================================
  Hits         6936     6936           
  Misses       3562     3562           
  Partials      395      395           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KjartanE
Copy link
Contributor Author

KjartanE commented Jan 3, 2023

See relevant SQL to run after this branch is merged. https://quartech.atlassian.net/browse/BHBC-2123 See text file attached to ticket.

@KjartanE KjartanE requested a review from cgarrettjones January 3, 2023 22:58
@KjartanE KjartanE merged commit c3e0a2b into dev Jan 4, 2023
@KjartanE KjartanE deleted the BHBC-2123 branch January 4, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants