BHC-2098: Refactor Functionality Used to Display Points on Map

[KjartanE]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2098

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-907-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-907-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=907

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-907-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-907-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=907

[codecov]

Codecov Report

Merging #907 (d9fe5e0) into dev (e63f674) will decrease coverage by 0.80%.
The diff coverage is 38.93%.

@@            Coverage Diff             @@
##              dev     #907      +/-   ##
==========================================
- Coverage   66.44%   65.64%   -0.80%     
==========================================
  Files         345      353       +8     
  Lines       11073    11304     +231     
  Branches     1944     1966      +22     
==========================================
+ Hits         7357     7421      +64     
- Misses       3299     3488     +189     
+ Partials      417      395      -22     

Impacted Files	Coverage Δ
app/src/components/map/MapContainer.tsx	75.00% <ø> (ø)
app/src/components/map/OccurrenceFeatureGroup.tsx	0.00% <0.00%> (-5.00%)	⬇️
...p/src/features/surveys/view/SurveyObservations.tsx	37.50% <0.00%> (-0.34%)	⬇️
app/src/features/surveys/view/SurveyPage.tsx	1.88% <0.00%> (-0.68%)	⬇️
...atures/surveys/view/components/SurveyStudyArea.tsx	3.57% <0.00%> (+0.12%)	⬆️
app/src/components/map/DatasetPopup.tsx	8.00% <8.00%> (ø)
app/src/components/map/FeaturePopup.tsx	8.00% <8.00%> (ø)
app/src/components/map/components/StaticLayers.tsx	12.50% <12.50%> (ø)
app/src/utils/Utils.ts	74.13% <12.50%> (-9.87%)	⬇️
api/src/utils/spatial-utils.ts	75.00% <13.33%> (-20.56%)	⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[anissa-agahchen]

Do you need package.json changes? The lock is changed.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

No Coverage information
0.1% Duplication