-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHBC-2076: Display Templates from S3 #910
Conversation
Openshift URLs for the PR Deployment: |
Codecov Report
@@ Coverage Diff @@
## dev #910 +/- ##
==========================================
- Coverage 66.48% 66.44% -0.05%
==========================================
Files 339 345 +6
Lines 10877 11073 +196
Branches 1908 1944 +36
==========================================
+ Hits 7232 7357 +125
- Misses 3243 3299 +56
- Partials 402 417 +15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Openshift URLs for the PR Deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was trying it in Openshfit, and the download button for a resource doesn't seem to work. The page refreshes and I get kicked back the the project list page, and no file is downloaded.
If I copy the url from the download button and paste it into my browser, then it does download the file, but clicking the button doesn't seem to work for me.
(Same behaviour in Firefox, Chrome and Edge)
Good catch! Fixed with 03a6bc3. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Overview
Render live S3 bucket contents on the Resources page.
Guide for updating templates: https://apps.nrs.gov.bc.ca/int/confluence/display/TASHIS/Updating+Resource+Templates
Links to Jira tickets
Description of relevant changes
PR Checklist
Code
Style
Documentation
Tests
Linting/Formatting
See the
lint
commands in package.jsonSee the
format
commands in package.jsonSonarCloud