BHBC-2160: Decorate DWCA Occurrences with Decimal Lat/Long

[KjartanE]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2160

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-919-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-919-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=919

[codecov]

Codecov Report

Merging #919 (af1d5d9) into dev (c2ddb87) will increase coverage by 0.03%.
The diff coverage is 75.51%.

@@            Coverage Diff             @@
##              dev     #919      +/-   ##
==========================================
+ Coverage   65.67%   65.71%   +0.03%     
==========================================
  Files         351      351              
  Lines       11287    11324      +37     
  Branches     1952     1966      +14     
==========================================
+ Hits         7413     7441      +28     
- Misses       3479     3480       +1     
- Partials      395      403       +8     

Impacted Files	Coverage Δ
api/src/repositories/occurrence-repository.ts	82.00% <ø> (ø)
app/src/utils/spatial-utils.tsx	18.51% <0.00%> (-0.35%)	⬇️
api/src/utils/spatial-utils.ts	69.44% <46.15%> (-5.56%)	⬇️
api/src/services/dwc-service.ts	89.79% <96.55%> (+4.08%)	⬆️
api/src/services/validation-service.ts	81.98% <100.00%> (+0.24%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[curtisupshall]

Couple of comments but looks great! +1 for project + survey seeder 😊🙌

[curtisupshall]

🥺

[anissa-agahchen]

In testing locally, I see that the object is decorating correctly and will display correctly.

However on refresh, I get:

[anissa-agahchen]

In testing locally, I see that the object is decorating correctly and will display correctly.

However on refresh, I get:

On further testing, it's because I had a record that didn't have either lat long or UTM ... will need to account for that in the back end

[KjartanE]

In testing locally, I see that the object is decorating correctly and will display correctly.
However on refresh, I get:

On further testing, it's because I had a record that didn't have either lat long or UTM ... will need to account for that in the back end

Thank you, I figured if I covered possible outcome with the decoration this error would not happen. But to avoid possible bad states and to handle this error, I added extra check for the Lat, Long values before they are used to display a data point.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication