Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Validation - string/number manipulations #922

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Fix: Validation - string/number manipulations #922

merged 8 commits into from
Jan 27, 2023

Conversation

anissa-agahchen
Copy link
Contributor

@anissa-agahchen anissa-agahchen commented Jan 26, 2023

Overview

Links to Jira tickets

-Small changes to fix small validation issues

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #922 (dd52444) into dev (192a334) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##              dev     #922      +/-   ##
==========================================
- Coverage   65.74%   65.73%   -0.02%     
==========================================
  Files         351      351              
  Lines       11317    11319       +2     
  Branches     1962     1963       +1     
==========================================
  Hits         7440     7440              
- Misses       3474     3475       +1     
- Partials      403      404       +1     
Impacted Files Coverage Δ
...rc/utils/media/csv/validation/csv-row-validator.ts 87.09% <33.33%> (-1.43%) ⬇️
...src/utils/media/xlsx/validation/xlsx-validation.ts 93.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anissa-agahchen anissa-agahchen changed the title Fix: Validation - string manipulation Fix: Validation - string/number manipulations Jan 26, 2023
KjartanE
KjartanE previously approved these changes Jan 27, 2023
Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KjartanE KjartanE merged commit 23e8fe0 into dev Jan 27, 2023
@KjartanE KjartanE deleted the fix-validation branch January 27, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants