BHBC-2153-2156: Remove 'All Areas Surveyed' Component, FOIPA and SEDIS Agreements Selected

[KjartanE]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2156
• https://quartech.atlassian.net/browse/BHBC-2153

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-923-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-923-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=923

[codecov]

Codecov Report

Merging #923 (44931b1) into dev (7e95183) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #923      +/-   ##
==========================================
+ Coverage   65.71%   65.74%   +0.03%     
==========================================
  Files         351      351              
  Lines       11324    11317       -7     
  Branches     1966     1962       -4     
==========================================
- Hits         7441     7440       -1     
+ Misses       3480     3474       -6     
  Partials      403      403              

Impacted Files	Coverage Δ
api/src/models/survey-view.ts	100.00% <ø> (ø)
api/src/paths/project/{projectId}/survey/create.ts	93.54% <ø> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts	93.75% <ø> (ø)
...roject/{projectId}/survey/{surveyId}/update/get.ts	86.11% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts	95.83% <ø> (ø)
api/src/paths/project/{projectId}/surveys.ts	96.29% <ø> (ø)
api/src/repositories/project-repository.ts	83.92% <ø> (ø)
api/src/repositories/survey-repository.ts	94.94% <ø> (ø)
api/src/services/eml-service.ts	12.21% <ø> (+0.16%)	⬆️
...s/surveys/components/PurposeAndMethodologyForm.tsx	75.00% <ø> (+25.00%)	⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[curtisupshall]

Looks good! Tested changes made to survey workflows.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
7.1% Duplication