Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2144: Fix Project Team Member interface + Amend system user GUID implementation #926

Merged
merged 16 commits into from
Jan 30, 2023

Conversation

curtisupshall
Copy link
Contributor

Overview

Links to Jira tickets

Description of relevant changes

  • Fixes a bug with adding participants to a project;
  • Removes the User GUID text field from the Add System User form;
  • Makes the user_guid property in the system_users table nullable;
  • Adds a service method for finding users by user identifier + identity source;
  • Adds a function which patches the user's GUID entry whenever their user context is set during a database connection.

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #926 (1fa86fd) into dev (b7dd6a4) will increase coverage by 0.02%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##              dev     #926      +/-   ##
==========================================
+ Coverage   65.73%   65.75%   +0.02%     
==========================================
  Files         351      349       -2     
  Lines       11319    11317       -2     
  Branches     1963     1961       -2     
==========================================
+ Hits         7440     7441       +1     
+ Misses       3475     3471       -4     
- Partials      404      405       +1     
Impacted Files Coverage Δ
api/src/models/user.ts 69.23% <ø> (ø)
.../src/paths/project/{projectId}/participants/get.ts 96.00% <ø> (ø)
api/src/paths/user/list.ts 85.71% <ø> (ø)
api/src/queries/queries.ts 100.00% <ø> (ø)
app/src/features/admin/users/ActiveUsersList.tsx 32.50% <ø> (ø)
...pp/src/features/admin/users/AddSystemUsersForm.tsx 20.00% <ø> (+2.60%) ⬆️
api/src/repositories/user-repository.ts 97.87% <75.00%> (-2.13%) ⬇️
api/src/services/user-service.ts 62.90% <85.71%> (+2.18%) ⬆️
api/src/database/db.ts 85.98% <92.30%> (+2.17%) ⬆️
...c/paths/project/{projectId}/participants/create.ts 86.11% <100.00%> (-0.38%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura
Copy link
Collaborator

Just curious regarding the set guid sql + set context sql: was there no way to do it in 1 call in the end? Because of the views, or the way functions work?

api/src/database/db.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ☄️

@curtisupshall curtisupshall merged commit 5e7a6a2 into dev Jan 30, 2023
@curtisupshall curtisupshall deleted the BHBC-2144 branch January 30, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants