BHBC-2145: Fix bug re: validation completion flag #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Openshift URLs for the PR Deployment: |
NickPhura
previously approved these changes
Jan 30, 2023
Codecov Report
@@ Coverage Diff @@
## dev #927 +/- ##
==========================================
- Coverage 65.75% 65.75% -0.01%
==========================================
Files 349 349
Lines 11317 11314 -3
Branches 1961 1961
==========================================
- Hits 7441 7439 -2
Misses 3471 3471
+ Partials 405 404 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anissa-agahchen
previously approved these changes
Jan 30, 2023
NickPhura
reviewed
Jan 30, 2023
api/src/paths/project/{projectId}/survey/{surveyId}/observation/submission/get.ts
Show resolved
Hide resolved
anissa-agahchen
previously approved these changes
Jan 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
anissa-agahchen
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug which causes the
isValidatingflag to be stuck ontruefor an occurrence submission that has finished validating.