Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates #929

Merged
merged 7 commits into from
Jan 31, 2023
Merged

UI updates #929

merged 7 commits into from
Jan 31, 2023

Conversation

jeznorth
Copy link
Contributor

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #929 (19a8c1f) into dev (bb131b4) will increase coverage by 0.02%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##              dev     #929      +/-   ##
==========================================
+ Coverage   65.75%   65.77%   +0.02%     
==========================================
  Files         349      349              
  Lines       11314    11309       -5     
  Branches     1961     1961              
==========================================
  Hits         7439     7439              
+ Misses       3471     3466       -5     
  Partials      404      404              
Impacted Files Coverage Δ
app/src/components/attachments/AttachmentsList.tsx 3.61% <ø> (ø)
...rc/components/boundary/InferredLocationDetails.tsx 20.00% <0.00%> (ø)
app/src/components/surveys/SurveysList.tsx 100.00% <ø> (ø)
app/src/features/admin/users/UsersDetailHeader.tsx 73.33% <0.00%> (-3.34%) ⬇️
...rojects/participants/ProjectParticipantsHeader.tsx 0.00% <0.00%> (ø)
app/src/features/projects/view/ProjectHeader.tsx 4.16% <ø> (+0.08%) ⬆️
...eatures/projects/view/components/FundingSource.tsx 81.81% <ø> (ø)
...ures/projects/view/components/LocationBoundary.tsx 3.33% <ø> (ø)
...features/projects/view/components/Partnerships.tsx 100.00% <ø> (ø)
app/src/features/surveys/edit/EditSurveyPage.tsx 0.00% <ø> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@curtisupshall curtisupshall merged commit a746dba into dev Jan 31, 2023
@curtisupshall curtisupshall deleted the ui-updates branch January 31, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants