-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHBC-2183: Re-enable/fix required column value validator #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openshift URLs for the PR Deployment: |
curtisupshall
approved these changes
Jan 31, 2023
Codecov Report
@@ Coverage Diff @@
## dev #931 +/- ##
==========================================
- Coverage 65.77% 65.76% -0.02%
==========================================
Files 349 349
Lines 11309 11304 -5
Branches 1961 1960 -1
==========================================
- Hits 7439 7434 -5
- Misses 3466 3467 +1
+ Partials 404 403 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Links to Jira tickets
https://quartech.atlassian.net/browse/BHBC-2183
Description of relevant changes
Fix/enable semi-finished validator function that checks if a column's cells are empty when they should not be.
PR Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
Code
Style
Documentation
Tests
Linting/Formatting
See the
lint
commands in package.jsonSee the
format
commands in package.jsonSonarCloud