Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2183: Re-enable/fix required column value validator #931

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Jan 31, 2023

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2183

Description of relevant changes

Fix/enable semi-finished validator function that checks if a column's cells are empty when they should not be.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #931 (299305f) into dev (598464b) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##              dev     #931      +/-   ##
==========================================
- Coverage   65.77%   65.76%   -0.02%     
==========================================
  Files         349      349              
  Lines       11309    11304       -5     
  Branches     1961     1960       -1     
==========================================
- Hits         7439     7434       -5     
- Misses       3466     3467       +1     
+ Partials      404      403       -1     
Impacted Files Coverage Δ
api/src/json-schema/validation-schema.ts 100.00% <ø> (ø)
...utils/media/validation/validation-schema-parser.ts 73.73% <ø> (ø)
...rc/utils/media/csv/validation/csv-row-validator.ts 86.55% <87.50%> (-0.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NickPhura NickPhura merged commit a9ea67b into dev Feb 1, 2023
@NickPhura NickPhura deleted the BHBC-2183 branch February 1, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants