Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2184: Fix DwCArchive generation #934

Merged
merged 14 commits into from
Feb 7, 2023
Merged

BHBC-2184: Fix DwCArchive generation #934

merged 14 commits into from
Feb 7, 2023

Conversation

anissa-agahchen
Copy link
Contributor

@anissa-agahchen anissa-agahchen commented Feb 1, 2023

Overview

Links to Jira tickets

(https://quartech.atlassian.net/browse/BHBC-2138)
(https://quartech.atlassian.net/browse/BHBC-2160)

Description of relevant changes

Previous process:

  • transform xlsx file, store in s3, read from s3, generate workbook and store JSON in DB, decorate, scrape and upload spatial points (problem: the s3 file was missing the decorated content).
    New process:
  • transform xlsx file, decorate, store JSON in DB, scrape and upload spatial points, generate workbook and store in S3

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #934 (7e83625) into dev (f6401aa) will decrease coverage by 0.06%.
The diff coverage is 83.78%.

@@            Coverage Diff             @@
##              dev     #934      +/-   ##
==========================================
- Coverage   65.73%   65.68%   -0.06%     
==========================================
  Files         350      350              
  Lines       11327    11318       -9     
  Branches     1961     1959       -2     
==========================================
- Hits         7446     7434      -12     
- Misses       3477     3481       +4     
+ Partials      404      403       -1     
Impacted Files Coverage Δ
...d}/survey/{surveyId}/observation/submission/get.ts 83.33% <ø> (ø)
api/src/services/occurrence-service.ts 95.23% <ø> (ø)
api/src/services/validation-service.ts 81.57% <82.35%> (-0.41%) ⬇️
api/src/paths/xlsx/process.ts 96.87% <100.00%> (+2.28%) ⬆️
api/src/services/dwc-service.ts 82.05% <100.00%> (-7.75%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anissa-agahchen anissa-agahchen changed the title Fix dwc decorate Fix DwCArchive generation Feb 1, 2023
@NickPhura NickPhura changed the title Fix DwCArchive generation BHBC-2184: Fix DwCArchive generation Feb 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NickPhura NickPhura self-requested a review February 7, 2023 17:40
@NickPhura NickPhura merged commit 9a18eaf into dev Feb 7, 2023
@NickPhura NickPhura deleted the fix-dwc-decorate branch February 7, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants