Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2140: Add splash dialog for upcoming production release #935

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2140

Description of relevant changes

Add splash dialog alert notifying users of upcoming production release.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@NickPhura NickPhura changed the title BHBC-2140: Add alert for upcoming production release BHBC-2140: Add splash dialog for upcoming production release Feb 2, 2023
@NickPhura NickPhura requested a review from jeznorth February 2, 2023 17:25
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #935 (c30f449) into dev (a9ea67b) will decrease coverage by 0.03%.
The diff coverage is 52.17%.

@@            Coverage Diff             @@
##              dev     #935      +/-   ##
==========================================
- Coverage   65.76%   65.73%   -0.03%     
==========================================
  Files         349      350       +1     
  Lines       11304    11327      +23     
  Branches     1960     1961       +1     
==========================================
+ Hits         7434     7446      +12     
- Misses       3467     3477      +10     
- Partials      403      404       +1     
Impacted Files Coverage Δ
app/src/components/layout/Header.tsx 80.95% <0.00%> (-4.05%) ⬇️
app/src/components/dialog/SplashDialog.tsx 54.54% <54.54%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶

@NickPhura NickPhura merged commit 790052d into dev Feb 2, 2023
@NickPhura NickPhura deleted the BHBC-2140 branch February 2, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants