BHBC-2140: Revert Splash Dialog Component #938

NickPhura · 2023-02-07T21:58:31Z

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2140

Description of relevant changes

Revert (delete) hardcoded splash dialog component.

Removes some (not all) of the code from these 2 PRs:

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
I have avoided duplicating code when possible, moving re-usable pieces into functions
I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
My code changes account for null/undefined values and handle errors appropriately
My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

My code follows the established style conventions
My code uses native material-ui components/icons/conventions when possible

Documentation

I have commented my code sufficiently, such that an unfamiliar developer could understand my code
I have added/updated README's and related documentation, as needed

Tests

I have added/updated unit tests for any code I've added/updated
I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

I have run the linter and fixed any issues, as needed
See the lint commands in package.json
I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

github-actions · 2023-02-07T21:58:46Z

Openshift URLs for the PR Deployment:

codecov · 2023-02-07T22:02:00Z

Codecov Report

Merging #938 (b88ce9b) into dev (9a18eaf) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #938      +/-   ##
==========================================
+ Coverage   65.68%   65.71%   +0.02%     
==========================================
  Files         350      349       -1     
  Lines       11318    11295      -23     
  Branches     1959     1958       -1     
==========================================
- Hits         7434     7422      -12     
+ Misses       3481     3471      -10     
+ Partials      403      402       -1