Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2212, 2213 - UI bug fixes for prod release #945

Merged
merged 10 commits into from
Feb 11, 2023
Merged

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Feb 10, 2023

Overview

Addresses two bugs for prod release.

Links to Jira tickets

Description of relevant changes

  • Fixes a bug when editing projects having null Project Agency ID for Funding Source
  • Fixes a bug when clicking Read More on a truncated text field that doesn't contained a . character.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #945 (447a371) into dev (6ee2cb5) will decrease coverage by 0.02%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##              dev     #945      +/-   ##
==========================================
- Coverage   65.79%   65.77%   -0.02%     
==========================================
  Files         350      350              
  Lines       11310    11303       -7     
  Branches     1961     1959       -2     
==========================================
- Hits         7441     7435       -6     
+ Misses       3471     3470       -1     
  Partials      398      398              
Impacted Files Coverage Δ
api/src/paths/project/{projectId}/update.ts 90.62% <ø> (ø)
app/src/features/projects/edit/EditProjectPage.tsx 0.00% <0.00%> (ø)
app/src/components/fields/ReadMoreField.tsx 100.00% <100.00%> (ø)
...res/projects/view/components/ProjectObjectives.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@curtisupshall curtisupshall marked this pull request as ready for review February 11, 2023 00:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@NickPhura NickPhura merged commit 051eb6c into dev Feb 11, 2023
@NickPhura NickPhura deleted the BHBC-2212-2213 branch February 11, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants