Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2169: Implement DwCA call to BioHub DwCA Submission API when Observations are Submitted #953

Merged
merged 25 commits into from
Feb 22, 2023

Conversation

AlfredRosenthal
Copy link
Contributor

Overview

Links to Jira tickets

BHBC-2169

Description of relevant changes

  • Updated Biohub submission code to hit new queue endpoint
  • updated that same call to insert into new publish tables
  • created new repo/ service to handle publish tables

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #953 (1e28ff0) into dev (bc59b7c) will increase coverage by 0.07%.
The diff coverage is 74.39%.

@@            Coverage Diff             @@
##              dev     #953      +/-   ##
==========================================
+ Coverage   65.74%   65.82%   +0.07%     
==========================================
  Files         350      352       +2     
  Lines       11298    11373      +75     
  Branches     1961     1976      +15     
==========================================
+ Hits         7428     7486      +58     
- Misses       3472     3485      +13     
- Partials      398      402       +4     
Impacted Files Coverage Δ
api/src/services/project-service.ts 20.93% <0.00%> (ø)
api/src/services/platform-service.ts 81.01% <43.47%> (-15.60%) ⬇️
api/src/repositories/survey-repository.ts 94.47% <66.66%> (-0.47%) ⬇️
api/src/services/history-publish-service.ts 66.66% <66.66%> (ø)
api/src/services/survey-service.ts 82.14% <66.66%> (+0.12%) ⬆️
api/src/repositories/history-publish-repository.ts 100.00% <100.00%> (ø)
api/src/__mocks__/db.ts 100.00% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlfredRosenthal AlfredRosenthal marked this pull request as ready for review February 18, 2023 00:38
@curtisupshall curtisupshall changed the title BHBC-2169 BHBC-2169: Implement DwCA call to BioHub DwCA Submission API when Observations are Submitted Feb 21, 2023
curtisupshall
curtisupshall previously approved these changes Feb 21, 2023
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

api/src/services/platform-service.ts Outdated Show resolved Hide resolved
api/src/services/project-service.ts Outdated Show resolved Hide resolved
curtisupshall
curtisupshall previously approved these changes Feb 22, 2023
Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for JS docs. Looks good!

api/src/services/platform-service.ts Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@curtisupshall curtisupshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@AlfredRosenthal AlfredRosenthal merged commit 359656f into dev Feb 22, 2023
@curtisupshall curtisupshall deleted the BHBC-2169 branch February 22, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants