Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2221: Experimental Git Action Improvements #957

Merged
merged 7 commits into from
Feb 23, 2023
Merged

BHBC-2221: Experimental Git Action Improvements #957

merged 7 commits into from
Feb 23, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2221

Description of relevant changes

  • Add skip duplicate checks action to skip actions that have previously run and have no new file changes.
  • Fix massive performance issue with installing pipeline packages (see diff of pipeline-cli in the .../.pipeline/package.json)
  • Better async handling in pipeline scripts
  • Updates to the fork of pipeline-cli we are using to add better logging
  • Misc git action/pipelien cleanup

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #957 (1ac057a) into dev (359656f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #957   +/-   ##
=======================================
  Coverage   65.82%   65.82%           
=======================================
  Files         352      352           
  Lines       11373    11373           
  Branches     1976     1976           
=======================================
  Hits         7486     7486           
  Misses       3485     3485           
  Partials      402      402           
Impacted Files Coverage Δ
api/src/repositories/attachment-repository.ts 93.06% <ø> (ø)
api/src/services/gcnotify-service.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura
Copy link
Collaborator Author

NickPhura commented Feb 23, 2023

I will need to update the required checks setting in GitHub as they are being changed as part of this PR, but I won't change them until this PR is ready to be merged so that It doesn't block any other PRs that are still using the old checks.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants