BHBC-2226-hotfix: Amend write path in S3 for survey attachments (#960)

[NickPhura]

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2226

• Applying as a hotfix to prod

Description of relevant changes

See original PR to dev: #960

This branch created by cherry-picking the commit from Dev.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-963-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-963-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=963

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #963 (e3927df) into prod (55c37bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             prod     #963   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files         350      350           
  Lines       11305    11305           
  Branches     1960     1960           
=======================================
  Hits         7436     7436           
  Misses       3471     3471           
  Partials      398      398           

Impacted Files	Coverage Δ
api/src/services/attachment-service.ts	100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more