Tech debt: decouple upload to Biohub from create/update project/survey

[anissa-agahchen]

Overview

Links to Jira tickets

• {List all applicable Jira tickets}

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-969-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-969-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=969

[codecov]

Codecov Report

Merging #969 (7d5d6b5) into dev (b54b603) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #969      +/-   ##
==========================================
+ Coverage   65.98%   66.02%   +0.04%     
==========================================
  Files         358      358              
  Lines       11645    11651       +6     
  Branches     2014     2014              
==========================================
+ Hits         7684     7693       +9     
+ Misses       3556     3553       -3     
  Partials      405      405              

Impacted Files	Coverage Δ
api/src/paths/project/create.ts	96.00% <100.00%> (ø)
api/src/paths/project/{projectId}/survey/create.ts	96.15% <100.00%> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts	96.15% <100.00%> (ø)
api/src/paths/project/{projectId}/update.ts	91.52% <100.00%> (ø)
api/src/services/project-service.ts	23.42% <100.00%> (+2.49%)	⬆️
api/src/services/survey-service.ts	83.21% <100.00%> (+1.07%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-969-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-969-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=969

[AlfredRosenthal]

🐶

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication