BHBC-2246: More Data admin permissions #971

AlfredRosenthal · 2023-03-15T00:20:49Z

Overview

Links to Jira tickets

{List all applicable Jira tickets}

Description of relevant changes

{List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
I have avoided duplicating code when possible, moving re-usable pieces into functions
I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
My code changes account for null/undefined values and handle errors appropriately
My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

My code follows the established style conventions
My code uses native material-ui components/icons/conventions when possible

Documentation

I have commented my code sufficiently, such that an unfamiliar developer could understand my code
I have added/updated README's and related documentation, as needed

Tests

I have added/updated unit tests for any code I've added/updated
I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

I have run the linter and fixed any issues, as needed
See the lint commands in package.json
I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

github-actions · 2023-03-15T00:22:08Z

Openshift URLs for the PR Deployment:

github-actions · 2023-03-15T00:22:12Z

Openshift URLs for the PR Deployment:

codecov · 2023-03-15T00:25:22Z

Codecov Report

Merging #971 (5918993) into dev (dfef452) will decrease coverage by 0.03%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##              dev     #971      +/-   ##
==========================================
- Coverage   66.02%   66.00%   -0.03%     
==========================================
  Files         358      358              
  Lines       11651    11655       +4     
  Branches     2014     2015       +1     
==========================================
  Hits         7693     7693              
- Misses       3553     3557       +4     
  Partials      405      405

Impacted Files	Coverage Δ
api/src/paths/publish/survey.ts	`95.65% <ø> (ø)`
api/src/services/platform-service.ts	`90.86% <0.00%> (-2.00%)`	⬇️
.../src/paths/project/{projectId}/attachments/list.ts	`96.29% <100.00%> (ø)`
...s/project/{projectId}/attachments/report/upload.ts	`91.66% <100.00%> (ø)`
...rc/paths/project/{projectId}/attachments/upload.ts	`91.89% <100.00%> (ø)`
...t/{projectId}/attachments/{attachmentId}/delete.ts	`96.87% <100.00%> (ø)`
...jectId}/attachments/{attachmentId}/getSignedUrl.ts	`96.66% <100.00%> (ø)`
...jectId}/attachments/{attachmentId}/metadata/get.ts	`96.00% <100.00%> (ø)`
...tId}/attachments/{attachmentId}/metadata/update.ts	`93.75% <100.00%> (ø)`
...c/paths/project/{projectId}/participants/create.ts	`86.11% <100.00%> (ø)`
... and 3 more