BHBC-2195-2: Client changes and fixes

[KjartanE]

Overview

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2195
• https://quartech.atlassian.net/browse/BHBC-2166

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-975-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-975-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=975

[codecov]

Codecov Report

Merging #975 (d94cef8) into dev (1a27ee4) will decrease coverage by 0.19%.
The diff coverage is 84.37%.

@@            Coverage Diff             @@
##              dev     #975      +/-   ##
==========================================
- Coverage   66.71%   66.52%   -0.19%     
==========================================
  Files         358      357       -1     
  Lines       11644    11587      -57     
  Branches     2010     1996      -14     
==========================================
- Hits         7768     7708      -60     
  Misses       3465     3465              
- Partials      411      414       +3     

Impacted Files	Coverage Δ
app/src/components/publish/SelectAllButton.tsx	10.52% <0.00%> (-2.81%)	⬇️
app/src/hooks/api/useSurveyApi.ts	27.84% <ø> (-0.21%)	⬇️
api/src/services/survey-service.ts	80.53% <71.42%> (-1.54%)	⬇️
api/src/services/project-service.ts	24.86% <75.00%> (+1.43%)	⬆️
api/src/services/platform-service.ts	92.51% <89.00%> (+1.41%)	⬆️
api/src/paths/project/create.ts	96.00% <100.00%> (ø)
api/src/paths/project/{projectId}/survey/create.ts	96.15% <100.00%> (ø)
...hs/project/{projectId}/survey/{surveyId}/delete.ts	94.59% <100.00%> (ø)
...hs/project/{projectId}/survey/{surveyId}/update.ts	96.15% <100.00%> (ø)
api/src/paths/project/{projectId}/update.ts	91.52% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[curtisupshall]

Looks great!