Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2268: Add Zod #979

Merged
merged 3 commits into from
Mar 21, 2023
Merged

BHBC-2268: Add Zod #979

merged 3 commits into from
Mar 21, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2268

Description of relevant changes

Not specifically tied to BHBC-2268, but some initial changes that will be used in follow up PRs for BHBC-2268. PRing this first separately just to keep it smaller.

  • Add Zod to db.ts

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #979 (47ebdb6) into dev (8b7a071) will decrease coverage by 0.03%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##              dev     #979      +/-   ##
==========================================
- Coverage   66.52%   66.49%   -0.03%     
==========================================
  Files         357      358       +1     
  Lines       11587    11604      +17     
  Branches     1996     2000       +4     
==========================================
+ Hits         7708     7716       +8     
- Misses       3465     3472       +7     
- Partials      414      416       +2     
Impacted Files Coverage Δ
api/src/database/db.ts 81.73% <50.00%> (-4.26%) ⬇️
api/src/database/db-utils.ts 75.00% <75.00%> (ø)
api/src/__mocks__/db.ts 96.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@KjartanE KjartanE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

@NickPhura NickPhura added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Mar 20, 2023
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥛

@NickPhura NickPhura merged commit f772ee6 into dev Mar 21, 2023
@NickPhura NickPhura deleted the BHBC-2268 branch March 21, 2023 17:26
KjartanE pushed a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants