Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2268-2: Update survey supplemental data to include publish data #980

Merged
merged 10 commits into from
Mar 22, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2268

Description of relevant changes

  • Update survey supplemental data section to include publish history records (for occurrence, summary, and survey metadata)

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #980 (9ac7ae3) into dev (6cd44da) will increase coverage by 0.15%.
The diff coverage is 90.16%.

@@            Coverage Diff             @@
##              dev     #980      +/-   ##
==========================================
+ Coverage   66.32%   66.47%   +0.15%     
==========================================
  Files         360      360              
  Lines       11646    11681      +35     
  Branches     2009     2015       +6     
==========================================
+ Hits         7724     7765      +41     
+ Misses       3504     3498       -6     
  Partials      418      418              
Impacted Files Coverage Δ
api/src/models/survey-view.ts 100.00% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts 95.83% <ø> (ø)
api/src/paths/project/{projectId}/surveys.ts 96.29% <ø> (ø)
...atures/surveys/view/components/SurveyStudyArea.tsx 3.17% <0.00%> (+0.23%) ⬆️
app/src/test-helpers/survey-helpers.ts 100.00% <ø> (ø)
...p/src/features/surveys/view/SurveyObservations.tsx 34.34% <40.00%> (-0.32%) ⬇️
api/src/services/survey-service.ts 80.12% <80.00%> (-0.41%) ⬇️
api/src/repositories/history-publish-repository.ts 100.00% <100.00%> (ø)
api/src/repositories/survey-repository.ts 94.28% <100.00%> (+0.91%) ⬆️
api/src/services/history-publish-service.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NickPhura NickPhura marked this pull request as ready for review March 21, 2023 17:27
api/src/repositories/survey-repository.ts Outdated Show resolved Hide resolved
api/src/services/survey-service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

@anissa-agahchen anissa-agahchen merged commit e929a94 into dev Mar 22, 2023
@anissa-agahchen anissa-agahchen deleted the BHBC-2268-2 branch March 22, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants