BHBC 1955: Summary Templates

[AlfredRosenthal]

Overview

Links to Jira tickets

BHBC-1955

Description of relevant changes

• updated displayed errors
• fixed sql fetching summary submission status

Testing

• PR Pod currently has all templates uploaded
• Download the 2.0 version Summary Templates from the resources page
• Create/ Open a project
• Create/ Open a Survey
• Edit survey to have desired species (Moose, Elk, Sheep, Goat or Caribou)
• upload species summary template to survey

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-981-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-981-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=981

[codecov]

Codecov Report

Merging #981 (bad99af) into dev (0931df0) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##              dev     #981      +/-   ##
==========================================
- Coverage   66.32%   66.32%   -0.01%     
==========================================
  Files         360      360              
  Lines       11641    11646       +5     
  Branches     2008     2009       +1     
==========================================
+ Hits         7721     7724       +3     
- Misses       3503     3504       +1     
- Partials      417      418       +1     

Impacted Files	Coverage Δ
api/src/services/eml-service.ts	46.46% <ø> (ø)
...src/features/surveys/view/SurveySummaryResults.tsx	2.17% <ø> (ø)
api/src/repositories/summary-repository.ts	92.30% <60.00%> (-2.70%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-981-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-981-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=981

[NickPhura]

@AlfredRosenthal where are we storing the configs for this (wanted to install them locally)?

[AlfredRosenthal]

@AlfredRosenthal where are we storing the configs for this (wanted to install them locally)?
The inserts/ update SQL can be found in confluence as well as a branch in the utils repository

[NickPhura]

@AlfredRosenthal Should validation errors be displayed? I get the message "Resolve the following errors in your local file and re-import." but no other errors are displayed. Unless there is some work needed there that isnt part of this ticket?

I assume the status/message display is pretty out of date, given the recent updates to observations. So probably just need to create a ticket for this if we dont have one already.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[NickPhura]

Tried Caribou locally, happy/sad paths