BHBC-2274: Router technical debt

[curtisupshall]

Overview

Fixes some minor annoyances + addresses some technical debt surrounding the app router

Links to Jira tickets

• https://quartech.atlassian.net/browse/BHBC-2274

Description of relevant changes

• Replaces normal anchor links with React Router links

• Removes unneccessary routes:

  • surveys/:survey_id/attachments
  • surveys/:survey_id/observations
  • surveys/:survey_id/results

• Removes <Layout> components that are already wrapped

• Fixes an issue with the Forbidden page, wherein users cannot navigate away from the forbidden page if the initial request to fetch the user's userdata fails. This often occurs during development when the app refreshes while the API is momentarily re-compiling.

Testing Procedures

0. Create a project and survey.
1. Click into the project, then click into the survey. It should:

• Fetch and render the survey immediately without reloading the webpage

2. From any page in SIMS, reload the browser while the API is rebuilding. You can achive this by going to api/src/app.ts in your IDE and saving the file, triggering a rebuild of the API. If this is successful, you should land on the Forbidden page in SIMS.
3. Wait until the API is finished rebuilding, then attempt to click away from the Forbidden page. You should:

• Successfully navigate away from the forbidden page

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-983-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-983-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=983

[codecov]

Codecov Report

Merging #983 (24bb0fe) into dev (b09d73c) will decrease coverage by 12.75%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##              dev     #983       +/-   ##
===========================================
- Coverage   80.85%   68.11%   -12.75%     
===========================================
  Files         177      378      +201     
  Lines        7027    11722     +4695     
  Branches     1225     1987      +762     
===========================================
+ Hits         5682     7984     +2302     
- Misses       1065     3290     +2225     
- Partials      280      448      +168     

Impacted Files	Coverage Δ
app/src/components/layout/Header.tsx	85.00% <ø> (ø)
app/src/components/map/DatasetPopup.tsx	8.69% <ø> (ø)
app/src/components/security/RouteGuards.tsx	0.00% <0.00%> (ø)
app/src/components/surveys/SurveysList.tsx	100.00% <ø> (ø)
app/src/features/admin/users/ActiveUsersList.tsx	32.50% <ø> (ø)
...p/src/features/admin/users/UsersDetailProjects.tsx	78.82% <ø> (ø)
app/src/features/projects/ProjectsRouter.tsx	0.00% <ø> (ø)
...es/projects/view/components/ProjectCoordinator.tsx	100.00% <ø> (ø)
app/src/features/surveys/CreateSurveyPage.tsx	2.77% <ø> (ø)
app/src/features/surveys/SurveyRouter.tsx	0.00% <ø> (ø)
... and 2 more

... and 189 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-983-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-983-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=983

[AlfredRosenthal]

📸

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[anissa-agahchen]

[AlfredRosenthal]

🐤

[curtisupshall]

Unrelated; Will write a ticket.

[anissa-agahchen]

Looks good!