BHBC-1955: Summary Messages Update

[AlfredRosenthal]

Overview

Description of relevant changes

• updated message type for missing header
• added check that survey species and template species line up properly

Testing

Scenario 1

• Get a summary template upsert script from biohubbc-utils
• Open DBeaver and run the summary template scripts
• Start SIMS
• download a summary template from the resources
• Create Project/ Survey
• Open summary template from resources page and remove an entire column
• Upload modified file and see Mandatory fields have not been filled error

Scenario 2

• Get a summary template upsert script from biohubbc-utils
• Open DBeaver and run the summary template scripts
• Start SIMS
• download a summary template from the resources
• Create Project/ Survey
• Upload a summary template intended for a different species than the one in the survey and see Failed to get validation rules error

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-986-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-986-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=986

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-986-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-986-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=986

[codecov]

Codecov Report

Merging #986 (dd571e3) into dev (3128221) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #986      +/-   ##
==========================================
- Coverage   66.47%   66.46%   -0.01%     
==========================================
  Files         360      360              
  Lines       11681    11684       +3     
  Branches     2015     2016       +1     
==========================================
+ Hits         7765     7766       +1     
- Misses       3498     3500       +2     
  Partials      418      418              

Impacted Files	Coverage Δ
api/src/services/summary-service.ts	80.35% <ø> (-1.79%)	⬇️
...src/features/surveys/view/SurveySummaryResults.tsx	2.17% <ø> (ø)
api/src/repositories/summary-repository.ts	92.64% <100.00%> (+0.33%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[anissa-agahchen]

Looks good!

[KjartanE]

🐈