BHBC-2251: EML Project/Survey type

[AlfredRosenthal]

Overview

Links to Jira tickets

BHBC-2251

Description of relevant changes

• EML generated during project submission will now be tagged with a project type 'PROJECT' or 'SURVEY'

Testing Steps

To test fully you will need to be running Biohub Platform on the BHBC-2251 branch

• Create a project in SIMS
• Add a Survey to the Project
• Submit Project to Biohub
• Open Biohub and search for newly created Project/ Survey
• Open the details for Project page
• See project specific details as well as Species Inventory Project under the project title
• Open the details for Survey page
• See survey specific details as well as Species Inventory Survey

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-993-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-993-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=993

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-993-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-993-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=993

[codecov]

Codecov Report

Merging #993 (c906355) into dev (e273dc3) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##              dev     #993      +/-   ##
==========================================
- Coverage   68.52%   68.50%   -0.02%     
==========================================
  Files         374      374              
  Lines       11669    11675       +6     
  Branches     1981     1981              
==========================================
+ Hits         7996     7998       +2     
- Misses       3227     3231       +4     
  Partials      446      446              

Impacted Files	Coverage Δ
api/src/services/eml-service.ts	46.07% <42.85%> (-0.39%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[curtisupshall]

Looks good. 🍦

[curtisupshall]

Survey Lead appears to be getting submitted correctly from SIMS to BioHub 👍