UI Updates / Fixes

[jeznorth]

Overview

Description of relevant changes

• Various layout / UI / content changes for survey functionality

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[codecov]

Codecov Report

Merging #996 (4fd7b74) into dev (67836d6) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##              dev     #996   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files         378      378           
  Lines       11722    11723    +1     
  Branches     1987     1987           
=======================================
+ Hits         7984     7985    +1     
  Misses       3290     3290           
  Partials      448      448           

Impacted Files	Coverage Δ
app/src/components/chips/SubmitStatusChip.tsx	75.00% <ø> (ø)
app/src/components/layout/Header.tsx	85.00% <ø> (ø)
app/src/components/publish/PublishDialogs.tsx	60.00% <ø> (ø)
app/src/components/publish/SubmissionAlertBar.tsx	2.85% <0.00%> (ø)
app/src/features/projects/view/ProjectHeader.tsx	4.87% <ø> (ø)
...pp/src/features/surveys/view/SurveyAttachments.tsx	65.21% <ø> (ø)
...rc/features/surveys/view/SurveyAttachmentsList.tsx	61.11% <ø> (ø)
app/src/features/surveys/view/SurveyPage.tsx	12.50% <ø> (ø)
...rveys/view/components/SurveyGeneralInformation.tsx	80.00% <ø> (ø)
...veys/view/summary-results/SurveySummaryResults.tsx	2.04% <ø> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlfredRosenthal]

🐕

[curtisupshall]

Resolved merge conflict with dev

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
17.2% Duplication