VDYP-168 Validate FIPStart input data #19
Conversation
… properties and common variables in VDYP7 Fortran.
|
SonarCloud Quality Gate failed.
|
| .reduce(0.0f, (x, y) -> x + y); | ||
| if (Math.abs(percentTotal - 100f) > 0.01f) { | ||
| throw validationError( | ||
| "Polygon %s has %s layer where species entries have a percentage total that does not sum to 100%%.", |
There was a problem hiding this comment.
In theory, this test is actually testing that the percentage is greater than 100 and thus the Validation Error should state that the sum > 100%.
| "message", | ||
| is( | ||
| "Polygon " + polygonId | ||
| + " has PRIMARY layer where species entries have a percentage total that does not sum to 100%." |
There was a problem hiding this comment.
I just put a couple of notes in that perhaps the error messages should be changed when checking for > 100% (error states sum not equal to 100). Mind you, if that is what is in the original Fortran and we are doing "like for like" ... perhaps the error messages should stay the same. We can update them in VDYP8. Other than that ... from what I can see ... looks good.
|
Update openshift-dev.yml
No description provided.