Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff linter: Ignore == to is rule #2650

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Ruff linter: Ignore == to is rule #2650

merged 2 commits into from
Feb 16, 2023

Conversation

conbrad
Copy link
Collaborator

@conbrad conbrad commented Feb 16, 2023

This rule will flag filter functions in numpy and sqlalchemy filters which will break the code.

See: astral-sh/ruff#2443

Test Links:

Landing Page
MoreCast 2.0
Percentile Calculator
MoreCast
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, but you could remove the two file based rules that ignore 712

, "app/db/crud/hfi_calc.py" = [
"E712",
], "app/db/crud/observations.py" = [
"E712",
]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #2650 (0f25beb) into main (0e115e9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2650   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         272      272           
  Lines        8597     8597           
  Branches      482      482           
=======================================
  Hits         7419     7419           
  Misses       1067     1067           
  Partials      111      111           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conbrad conbrad merged commit 15f9521 into main Feb 16, 2023
@conbrad conbrad deleted the task/adjust-linter-rule branch February 16, 2023 18:17
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
* Ignore == to is rule

* Remove duplicate ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants